<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 28, 2013 at 11:56 AM, Pavel Levshin <span dir="ltr"><<a href="mailto:pavel@levshin.spb.ru" target="_blank">pavel@levshin.spb.ru</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>Rainer,<br>
<br>
<br>
I see you are preparing for 1.0.0 release of liblognorm. Libestr
removal from internals can be postponed to next minor release, but
we need to establish external interface. Instead of current
definition, which is<br>
<br>
int ln_normalize(ln_ctx ctx, char *str, es_size_t strLen, struct
json_object **json_p);<br>
<br>
I propose this:<br>
<br>
int ln_normalize(ln_ctx ctx, const char *str, size_t strLen,
struct json_object **json_p);<br>
<br>
Why use es_size_t, if we are gettind rid of libestr?<br></div></div></blockquote><div><br></div><div>ahh... excellent point, I have to admit I overlooked it. es_size_t has the advantage (IMHO) that it is 32 bits and saves us the overhead of passing 64 bits around. I cannot see any reasonable case where we have >2gig messages. How about using uint32_t instead (or just plain int, but...).<br>
<br></div><div>You were right in time to prevent publishing of the package ;)<br><br>Rainer <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">
<div>
<br>
<br>
This is a reminder, just in case.<br>
<br>
<br>
--<br>
Pavel Levshin<br>
<br>
<br>
25.11.2013 12:24, Rainer Gerhards:<br>
</div><div><div class="h5">
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Sun, Nov 24, 2013 at 11:35 AM,
Pavel Levshin <span dir="ltr"><<a href="mailto:pavel@levshin.spb.ru" target="_blank">pavel@levshin.spb.ru</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> <br>
Done, in the same branch on GitHub: <br>
<br>
<a href="https://github.com/flicker581/liblognorm/commits/master-json-c" target="_blank">https://github.com/flicker581/liblognorm/commits/master-json-c</a><br>
<br>
<br>
</div>
</blockquote>
<div><br>
</div>
<div>Thanks, already merged. I will later today see that I
integrate the mmlognorm changes, tying things together. It
will initially go into v8.<br>
<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> Also, I have
written a brief document on current rulebase syntax and
field types. As a user, I would say that liblognorm
lacks proper documentation, and this doc is better than
nothing. It is not sufficient, though.<br>
<br>
</div>
</blockquote>
<div><br>
</div>
<div>full ack, but there is so much to do and so little
time. And nobody wants to do the doc, so...<br>
<br>
</div>
<div>thanks for this effort, it's definitely useful.<br>
<br>
Rainer <br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> <br>
--<br>
Pavel Levshin<br>
<br>
<br>
<div>23.11.2013 0:33, Rainer Gerhards:<br>
</div>
<div>
<div>
<blockquote type="cite">
<p dir="ltr">Always looking for backward comp, i'd
say create a new one. </p>
<p dir="ltr">Sent from phone, thus brief. </p>
<div class="gmail_quote">Am 22.11.2013 21:19
schrieb "Pavel Levshin" <<a href="mailto:pavel@levshin.spb.ru" target="_blank">pavel@levshin.spb.ru</a>>:<br type="attribution">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> <br>
<div>22.11.2013 21:53, Pavel Levshin:<br>
<br>
</div>
<blockquote type="cite"> <br>
Please note that I've just found a
regression in my code: it is unable to
strip quote marks from "quote-string"
fields. I need to redo this part.<br>
<br>
</blockquote>
<br>
It is fixed now.<br>
<br>
I really feel that we need to implement some
facility to parse comma-separated logs,
where a field can have zero length. It is
easy to do, and it is a quite common log
format (I'm using it, for example). Now,
liblognorm is unable to parse it. There are
two ways:<br>
<br>
- change char-to behaviour to allow
zero-length matches<br>
- create a new field type, based on current
char-to<br>
<br>
What to prefer?<br>
<br>
<br>
--<br>
Pavel Levshin<br>
<br>
<br>
</div>
<br>
_______________________________________________<br>
Lognorm mailing list<br>
<a href="mailto:Lognorm@lists.adiscon.com" target="_blank">Lognorm@lists.adiscon.com</a><br>
<a href="http://lists.adiscon.net/mailman/listinfo/lognorm" target="_blank">http://lists.adiscon.net/mailman/listinfo/lognorm</a><br>
<br>
</blockquote>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
Lognorm mailing list
<a href="mailto:Lognorm@lists.adiscon.com" target="_blank">Lognorm@lists.adiscon.com</a>
<a href="http://lists.adiscon.net/mailman/listinfo/lognorm" target="_blank">http://lists.adiscon.net/mailman/listinfo/lognorm</a>
</pre>
</blockquote>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
Lognorm mailing list<br>
<a href="mailto:Lognorm@lists.adiscon.com" target="_blank">Lognorm@lists.adiscon.com</a><br>
<a href="http://lists.adiscon.net/mailman/listinfo/lognorm" target="_blank">http://lists.adiscon.net/mailman/listinfo/lognorm</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
Lognorm mailing list
<a href="mailto:Lognorm@lists.adiscon.com" target="_blank">Lognorm@lists.adiscon.com</a>
<a href="http://lists.adiscon.net/mailman/listinfo/lognorm" target="_blank">http://lists.adiscon.net/mailman/listinfo/lognorm</a>
</pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
Lognorm mailing list<br>
<a href="mailto:Lognorm@lists.adiscon.com">Lognorm@lists.adiscon.com</a><br>
<a href="http://lists.adiscon.net/mailman/listinfo/lognorm" target="_blank">http://lists.adiscon.net/mailman/listinfo/lognorm</a><br>
<br></blockquote></div><br></div></div>