[rsyslog] more 5.1.3 errors (fwd) / invalid fromhost

[Rainer Gerhards]

> > sounds good. do you have a patch (or a commit to revert) for step 2?
> 
> not yet, will see if I can create one today, but it may be useful to
> have the
> debug log (step 1) first. I understand that you would like to do both
> tests
> at once, but it depends a bit on how easy it is to "comment out" the
> code (I
> think it is easy). Will post an update later today.

David,

I think I have found the bug :) It was one of those that you actually
overlook while reviewing code, creating the test branches helped. I used an
"and" where an "or" war required in a predicate check, thus strings were
always re-used if the size of the former and the current string matched. That
would very well explain what you saw (the host IPs were of equal length). In
any case, it is a bug, and it is fixed in the master branch:

http://git.adiscon.com/?p=rsyslog.git;a=commitdiff;h=cdb58f8d913dc47b01f61f5a
72a83ce6aea26623

Just in case it should not address what you see, I have created two testing
branches for you: these are "david-test2a" and "david-test2b". They disable
different parts of the reuse logic (while crafting 2b I finally saw the
issue...).

Feedback appreciated.

Rainer