From rgerhards at hq.adiscon.com Fri Mar 6 12:25:18 2015 From: rgerhards at hq.adiscon.com (Rainer Gerhards) Date: Fri, 6 Mar 2015 12:25:18 +0100 Subject: [Lognorm] last call for next liblognorm release Message-ID: [re-sending due to typo in list mail address, any replies pls to this message!] Hi all, I am about to craft the next release. Please let me know today if there are any concerns or things that urgently need to go into it (and that I missed so far). Thanks, Rainer -------------- next part -------------- An HTML attachment was scrubbed... URL: From singh.janmejay at gmail.com Fri Mar 6 13:44:08 2015 From: singh.janmejay at gmail.com (singh.janmejay) Date: Fri, 6 Mar 2015 18:14:08 +0530 Subject: [Lognorm] last call for next liblognorm release In-Reply-To: References: Message-ID: I guess we should merge the open PR around behavior of floating-pt numbers in json-c 0.12 It'll ensure tests will pass on new json-c installs. I can merge it in if no one sees any concerns. -- Regards, Janmejay PS: Please blame the typos in this mail on my phone's uncivilized soft keyboard sporting it's not-so-smart-assist technology. On Mar 6, 2015 4:55 PM, "Rainer Gerhards" wrote: > [re-sending due to typo in list mail address, any replies pls to this > message!] > Hi all, > > I am about to craft the next release. > > Please let me know today if there are any concerns or things that urgently > need to go into it (and that I missed so far). > > Thanks, > Rainer > > _______________________________________________ > Lognorm mailing list > Lognorm at lists.adiscon.com > http://lists.adiscon.net/mailman/listinfo/lognorm > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From rgerhards at hq.adiscon.com Fri Mar 6 14:04:25 2015 From: rgerhards at hq.adiscon.com (Rainer Gerhards) Date: Fri, 6 Mar 2015 14:04:25 +0100 Subject: [Lognorm] last call for next liblognorm release In-Reply-To: References: Message-ID: Pls do Sent from phone, thus brief. Am 06.03.2015 13:44 schrieb "singh.janmejay" : > I guess we should merge the open PR around behavior of floating-pt numbers > in json-c 0.12 > > It'll ensure tests will pass on new json-c installs. > > I can merge it in if no one sees any concerns. > > -- > Regards, > Janmejay > > PS: Please blame the typos in this mail on my phone's uncivilized soft > keyboard sporting it's not-so-smart-assist technology. > > On Mar 6, 2015 4:55 PM, "Rainer Gerhards" > wrote: > >> [re-sending due to typo in list mail address, any replies pls to this >> message!] >> Hi all, >> >> I am about to craft the next release. >> >> Please let me know today if there are any concerns or things that >> urgently need to go into it (and that I missed so far). >> >> Thanks, >> Rainer >> >> _______________________________________________ >> Lognorm mailing list >> Lognorm at lists.adiscon.com >> http://lists.adiscon.net/mailman/listinfo/lognorm >> >> > _______________________________________________ > Lognorm mailing list > Lognorm at lists.adiscon.com > http://lists.adiscon.net/mailman/listinfo/lognorm > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From singh.janmejay at gmail.com Fri Mar 6 18:31:40 2015 From: singh.janmejay at gmail.com (singh.janmejay) Date: Fri, 6 Mar 2015 23:01:40 +0530 Subject: [Lognorm] last call for next liblognorm release In-Reply-To: <54F9D864.8000601@redhat.com> References: <54F9D864.8000601@redhat.com> Message-ID: You merged it already (the json 0.12 related PR). On Fri, Mar 6, 2015 at 10:10 PM, Tomas Heinrich wrote: > On 03/06/15 12:25, Rainer Gerhards wrote: >> >> I am about to craft the next release. >> >> Please let me know today if there are any concerns or things that >> urgently need to go into it (and that I missed so far). > > > Argh, I've just noticed one thing that probably qualifies... > > Couple of files in tests/ are licensed under ASL 2.0. > That license states that "You must give any other recipients of the Work or > Derivative Works a copy of this License". > The ASL 2.0 text is not distributed with liblognorm, currently. The rsyslog > tarball has it in COPYING.ASL20. > > Tomas > -- Regards, Janmejay http://codehunk.wordpress.com From rgerhards at hq.adiscon.com Fri Mar 6 18:32:51 2015 From: rgerhards at hq.adiscon.com (Rainer Gerhards) Date: Fri, 6 Mar 2015 18:32:51 +0100 Subject: [Lognorm] last call for next liblognorm release In-Reply-To: References: <54F9D864.8000601@redhat.com> Message-ID: 2015-03-06 18:31 GMT+01:00 singh.janmejay : > You merged it already (the json 0.12 related PR). > > great - wasn't sure if I actually did or just wanted to. Sometimes I want to but ultimately forget, especially if many small things go on concurrently ;) Rainer > On Fri, Mar 6, 2015 at 10:10 PM, Tomas Heinrich > wrote: > > On 03/06/15 12:25, Rainer Gerhards wrote: > >> > >> I am about to craft the next release. > >> > >> Please let me know today if there are any concerns or things that > >> urgently need to go into it (and that I missed so far). > > > > > > Argh, I've just noticed one thing that probably qualifies... > > > > Couple of files in tests/ are licensed under ASL 2.0. > > That license states that "You must give any other recipients of the Work > or > > Derivative Works a copy of this License". > > The ASL 2.0 text is not distributed with liblognorm, currently. The > rsyslog > > tarball has it in COPYING.ASL20. > > > > Tomas > > > > > > -- > Regards, > Janmejay > http://codehunk.wordpress.com > -------------- next part -------------- An HTML attachment was scrubbed... URL: From rgerhards at hq.adiscon.com Mon Mar 9 10:30:38 2015 From: rgerhards at hq.adiscon.com (Rainer Gerhards) Date: Mon, 9 Mar 2015 10:30:38 +0100 Subject: [Lognorm] last call for next liblognorm release In-Reply-To: <54F9D864.8000601@redhat.com> References: <54F9D864.8000601@redhat.com> Message-ID: 2015-03-06 17:40 GMT+01:00 Tomas Heinrich : > On 03/06/15 12:25, Rainer Gerhards wrote: > >> I am about to craft the next release. >> >> Please let me know today if there are any concerns or things that >> urgently need to go into it (and that I missed so far). >> > > Argh, I've just noticed one thing that probably qualifies... > > Couple of files in tests/ are licensed under ASL 2.0. > That license states that "You must give any other recipients of the Work > or Derivative Works a copy of this License". > The ASL 2.0 text is not distributed with liblognorm, currently. The > rsyslog tarball has it in COPYING.ASL20. > > Thx, I will add this. Rainer -------------- next part -------------- An HTML attachment was scrubbed... URL: From rgerhards at hq.adiscon.com Mon Mar 9 13:19:15 2015 From: rgerhards at hq.adiscon.com (Rainer Gerhards) Date: Mon, 9 Mar 2015 13:19:15 +0100 Subject: [Lognorm] last call for next liblognorm release In-Reply-To: References: <54F9D864.8000601@redhat.com> Message-ID: Just FYI: I have build problems on CENTOS 6. Will keep you updated. Rainer 2015-03-09 10:30 GMT+01:00 Rainer Gerhards : > 2015-03-06 17:40 GMT+01:00 Tomas Heinrich : > >> On 03/06/15 12:25, Rainer Gerhards wrote: >> >>> I am about to craft the next release. >>> >>> Please let me know today if there are any concerns or things that >>> urgently need to go into it (and that I missed so far). >>> >> >> Argh, I've just noticed one thing that probably qualifies... >> >> Couple of files in tests/ are licensed under ASL 2.0. >> That license states that "You must give any other recipients of the Work >> or Derivative Works a copy of this License". >> The ASL 2.0 text is not distributed with liblognorm, currently. The >> rsyslog tarball has it in COPYING.ASL20. >> >> > Thx, I will add this. > > Rainer > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From theinric at redhat.com Mon Mar 9 13:59:38 2015 From: theinric at redhat.com (Tomas Heinrich) Date: Mon, 09 Mar 2015 13:59:38 +0100 Subject: [Lognorm] last call for next liblognorm release In-Reply-To: References: <54F9D864.8000601@redhat.com> Message-ID: <54FD993A.1060902@redhat.com> On 03/09/15 13:19, Rainer Gerhards wrote: > Just FYI: I have build problems on CENTOS 6. Will keep you updated. Tried it myself on an updated el6 vm, looks like there are couple more bugs... First, for some reason (might be my vm is slightly broken), libestr.pc can't be found (might be related to this bz[0]). Defining the correct path helped: PKG_CONFIG_PATH=/lib64/pkgconfig:/usr/lib64/pkgconfig Then, I've noticed json_bool is not found by configure. The bug is robably (not 100% sure) that an include is missing: -AC_CHECK_TYPE(json_bool,,,) +AC_CHECK_TYPE(json_bool,,,[#include ]) Then the build still fails on type redefinition as HAVE_JSON_BOOL is not defined. This can be fixed by using a different macro: -AC_CHECK_TYPE(json_bool,,,[#include ]) +AC_CHECK_TYPES(json_bool,,,[#include ]) Then it finally compiles. Tomas [0] 1158842 - json-c pkgconfig files installed in the wrong place https://bugzilla.redhat.com/show_bug.cgi?id=1158842 From rgerhards at hq.adiscon.com Mon Mar 9 14:09:15 2015 From: rgerhards at hq.adiscon.com (Rainer Gerhards) Date: Mon, 9 Mar 2015 14:09:15 +0100 Subject: [Lognorm] last call for next liblognorm release In-Reply-To: <54FD993A.1060902@redhat.com> References: <54F9D864.8000601@redhat.com> <54FD993A.1060902@redhat.com> Message-ID: 2015-03-09 13:59 GMT+01:00 Tomas Heinrich : > On 03/09/15 13:19, Rainer Gerhards wrote: > >> Just FYI: I have build problems on CENTOS 6. Will keep you updated. >> > > Tried it myself on an updated el6 vm, looks like there are couple more > bugs... > > First, for some reason (might be my vm is slightly broken), libestr.pc > can't be found (might be related to this bz[0]). Defining the correct path > helped: > PKG_CONFIG_PATH=/lib64/pkgconfig:/usr/lib64/pkgconfig > Maybe a bug in libestr? > > Then, I've noticed json_bool is not found by configure. The bug is robably > (not 100% sure) that an include is missing: > -AC_CHECK_TYPE(json_bool,,,) > +AC_CHECK_TYPE(json_bool,,,[#include ]) > > Then the build still fails on type redefinition as HAVE_JSON_BOOL is not > defined. This can be fixed by using a different macro: > -AC_CHECK_TYPE(json_bool,,,[#include ]) > +AC_CHECK_TYPES(json_bool,,,[#include ]) > > I came to the same conclusion :-) Then it finally compiles. > ... but I also get some unexpected warnings, for which I did not yet find a cure. It's about json_object_object_get being depricated [0]. This is (kind of;)) being checked for in configure.ac as well. I thought the include file was missing here, too, but this definition doesn't make any difference: AC_CHECK_FUNCS(json_object_object_get_ex,,,[#include ]) Any idea? Rainer [0] enc_syslog.c: En la funci?n ?ln_fmtEventToRFC5424?: enc_syslog.c:186: aviso: ?json_object_object_get? es obsoleto (declarado en /usr/include/json-c/json_object.h:271) CC liblognorm_la-enc_csv.lo enc_csv.c: En la funci?n ?ln_fmtEventToCSV?: enc_csv.c:200: aviso: ?json_object_object_get? es obsoleto (declarado en /usr/include/json-c/json_object.h:271) CC liblognorm_la-enc_xml.lo enc_xml.c: En la funci?n ?ln_fmtEventToXML?: enc_xml.c:207: aviso: ?json_object_object_get? es obsoleto (declarado en /usr/include/json-c/json_object.h:271) CC liblognorm_la-json_compatibility.lo CCLD liblognorm.la CC lognormalizer-lognormalizer.o lognormalizer.c: En la funci?n ?eventHasTag?: lognormalizer.c:116: aviso: ?json_object_object_get? es obsoleto (declarado en /usr/include/json-c/json_object.h:271) lognormalizer.c: En la funci?n ?normalize?: lognormalizer.c:156: aviso: ?json_object_object_get? es obsoleto (declarado en /usr/include/json-c/json_object.h:271) CCLD lognormalizer > Tomas > > [0] 1158842 - json-c pkgconfig files installed in the wrong place > https://bugzilla.redhat.com/show_bug.cgi?id=1158842 > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From theinric at redhat.com Mon Mar 9 14:48:25 2015 From: theinric at redhat.com (Tomas Heinrich) Date: Mon, 09 Mar 2015 14:48:25 +0100 Subject: [Lognorm] last call for next liblognorm release In-Reply-To: References: <54F9D864.8000601@redhat.com> <54FD993A.1060902@redhat.com> Message-ID: <54FDA4A9.2060003@redhat.com> On 03/09/15 14:09, Rainer Gerhards wrote: > Maybe a bug in libestr? Turns out that it is a bug in the packaging. Filed as rhbz 1199995. > ... but I also get some unexpected warnings, for which I did not yet > find a cure. It's about json_object_object_get being depricated [0]. > > This is (kind of;)) being checked for in configure.ac > as well. I thought the include file was missing > here, too, but this definition doesn't make any difference: > > AC_CHECK_FUNCS(json_object_object_get_ex,,,[#include ]) > > Any idea? Uhm, doesn't it check for json_object_object_get_ex()? Maybe I don't get how those two are related. Either way, is the warning a real bug? It just warns that the function should be avoided in the future. The code in json_compatibility.c only handles the nonexistence of json_object_object_get_ex(), but explicitly references json_object_object_get(). > Rainer > > [0] > enc_syslog.c: En la funci?n ?ln_fmtEventToRFC5424?: What locale are you using? :] Tomas From rgerhards at hq.adiscon.com Tue Mar 10 09:28:17 2015 From: rgerhards at hq.adiscon.com (Rainer Gerhards) Date: Tue, 10 Mar 2015 09:28:17 +0100 Subject: [Lognorm] last call for next liblognorm release In-Reply-To: <54FDA4A9.2060003@redhat.com> References: <54F9D864.8000601@redhat.com> <54FD993A.1060902@redhat.com> <54FDA4A9.2060003@redhat.com> Message-ID: 2015-03-09 14:48 GMT+01:00 Tomas Heinrich : > On 03/09/15 14:09, Rainer Gerhards wrote: > >> Maybe a bug in libestr? >> > > Turns out that it is a bug in the packaging. Filed as rhbz 1199995. > > ... but I also get some unexpected warnings, for which I did not yet >> find a cure. It's about json_object_object_get being depricated [0]. >> >> This is (kind of;)) being checked for in configure.ac >> as well. I thought the include file was missing >> here, too, but this definition doesn't make any difference: >> >> AC_CHECK_FUNCS(json_object_object_get_ex,,,[#include ]) >> >> Any idea? >> > > Uhm, doesn't it check for json_object_object_get_ex()? Maybe I don't get > how those two are related. > > Either way, is the warning a real bug? It just warns that the function > should be avoided in the future. The code in json_compatibility.c only > handles the nonexistence of json_object_object_get_ex(), but explicitly > references json_object_object_get(). It's a warning, and it's not a real problem. But the detection of json_object_object_get_ex() does not work on el6. On other platforms, configure detects it, and so the old one is never used. On el6, it looks like it doesn't detect the function, and so the "json compatiblitly layer" in liblognorm is invoked, which calls the old function. A little bit of overhead involved, but mostly the issue is what's going on. In any case, I'll release with more or less cosmetic issue. We can always "fix" it later. Rainer > > > Rainer >> >> [0] >> enc_syslog.c: En la funci?n ?ln_fmtEventToRFC5424?: >> > > What locale are you using? :] > > Tomas > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From theinric at redhat.com Tue Mar 10 13:37:27 2015 From: theinric at redhat.com (Tomas Heinrich) Date: Tue, 10 Mar 2015 13:37:27 +0100 Subject: [Lognorm] last call for next liblognorm release In-Reply-To: References: <54F9D864.8000601@redhat.com> <54FD993A.1060902@redhat.com> <54FDA4A9.2060003@redhat.com> Message-ID: <54FEE587.7010401@redhat.com> On 03/10/15 09:28, Rainer Gerhards wrote: > It's a warning, and it's not a real problem. But the detection of > json_object_object_get_ex() does not work on el6. On other platforms, > configure detects it, and so the old one is never used. On el6, it looks > like it doesn't detect the function, and so the "json compatiblitly > layer" in liblognorm is invoked, which calls the old function. A little > bit of overhead involved, but mostly the issue is what's going on. OK, now I think I understand better. Here, on el6, configure actually picks it up: checking for json_object_object_get_ex... yes $ rpm -q json-c json-c-0.11-11.el6.x86_64 I still get warnings about json_object_object_get() being deprecated, but those are from different parts of the sources: lognormalizer.c:156: warning: ?json_object_object_get? is deprecated (declared at /usr/include/json-c/json_object.h:271) enc_xml.c:207: warning: 'json_object_object_get' is deprecated (declared at /usr/include/json-c/json_object.h:271) enc_csv.c:200: warning: 'json_object_object_get' is deprecated (declared at /usr/include/json-c/json_object.h:271) enc_syslog.c:186: warning: 'json_object_object_get' is deprecated (declared at /usr/include/json-c/json_object.h:271) > In any case, I'll release with more or less cosmetic issue. We can > always "fix" it later. Agreed. Tomas From friedl at adiscon.com Tue Mar 10 18:32:58 2015 From: friedl at adiscon.com (Florian Riedl) Date: Tue, 10 Mar 2015 18:32:58 +0100 Subject: [Lognorm] liblognorm 1.1.1 released Message-ID: Hi all, We have just released liblognorm 1.1.1. This release contains new parser syntaxes and some fixes. Changes: Version 1.1.1, 2015-03-09 - fixed library version numbering Thanks to Tomas Heinreich for reporting the problem. - added new parser syntaxes Thanks to Janmejay Singh for implementing most of them. - bugfix: function ln_parseFieldDescr() returns state value due to unitialized variable. This can also lead to invalid returning no sample node where one would have to be created. Download: http://www.liblognorm.com/download/liblognorm-1-1-1/ As always, feedback is appreciated. Best regards, Florian Riedl -------------- next part -------------- An HTML attachment was scrubbed... URL: